New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symfony 3.3 #3376
Symfony 3.3 #3376
Conversation
Also update tests urls
Waiting for K-Phoen/rulerz-bridge#1 to be merged by @K-Phoen 🕥 |
Rulerz-bridge 1.0.1 is out. |
# to be removed if we switch to (default) ISO8601 datetime instead of ATOM | ||
# see: https://github.com/schmittjoh/JMSSerializerBundle/pull/494 | ||
datetime: | ||
default_format: "Y-m-d\\TH:i:sO" # ATOM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be used only for the RSS/Atom feed, not the XML exports or other things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep but should we use the default one or keep the old one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
Since wallabag#3376, the web server console commands were not available.
Update to Symfony 3.3 and update restriction deps for all other deps (but some aren't compatible ATM, like this one FriendsOfSymfony/FOSRestBundle#1768).
For an easy review, you can avoid the
CS
commit and only check the other one.