Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 3.3 #3376

Merged
merged 3 commits into from Oct 11, 2017
Merged

Symfony 3.3 #3376

merged 3 commits into from Oct 11, 2017

Conversation

j0k3r
Copy link
Member

@j0k3r j0k3r commented Oct 9, 2017

Q A
Bug fix? maybe?
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation no
Translation no
Fixed tickets #...
License MIT

Update to Symfony 3.3 and update restriction deps for all other deps (but some aren't compatible ATM, like this one FriendsOfSymfony/FOSRestBundle#1768).

For an easy review, you can avoid the CS commit and only check the other one.

@j0k3r j0k3r added this to the 2.3.0 milestone Oct 9, 2017
@j0k3r
Copy link
Member Author

j0k3r commented Oct 9, 2017

Waiting for K-Phoen/rulerz-bridge#1 to be merged by @K-Phoen 🕥

@tcitworld
Copy link
Member

Rulerz-bridge 1.0.1 is out.

# to be removed if we switch to (default) ISO8601 datetime instead of ATOM
# see: https://github.com/schmittjoh/JMSSerializerBundle/pull/494
datetime:
default_format: "Y-m-d\\TH:i:sO" # ATOM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be used only for the RSS/Atom feed, not the XML exports or other things.

Copy link
Member Author

@j0k3r j0k3r Oct 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep but should we use the default one or keep the old one?

Copy link
Member

@nicosomb nicosomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@j0k3r j0k3r merged commit d8dc737 into 2.3 Oct 11, 2017
@j0k3r j0k3r deleted the symfony-3.3 branch October 11, 2017 07:55
@j0k3r j0k3r mentioned this pull request Oct 11, 2017
nclsHart added a commit to nclsHart/wallabag that referenced this pull request Oct 13, 2017
Since wallabag#3376, the web server console commands were not available.
@notFloran notFloran mentioned this pull request Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants